-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Requests 2.0.0 #1624
Conversation
6ad50c0
to
47c58e9
Compare
db70546
to
47c58e9
Compare
a58a9ef
to
272938b
Compare
Rebased and updated to test the latest changes in the Requests library. |
272938b
to
6ed8afa
Compare
6ed8afa
to
76fdec4
Compare
76fdec4
to
2d7768f
Compare
2d7768f
to
0425c8e
Compare
Marked as ready for review and updated with the final Requests 2.0.0 code. |
Closing as committed via changeset 52244. |
Re-opening as the commit was reverted. |
This has got a merge conflict and and older version of Requests.
The trac ticket for upgrade is tagged Mainly for my own notes: for the purposes of testing this is a randomly selected before zip file. |
Sorry @jrfnl, I just noticed there isn't a patch for https://core.trac.wordpress.org/ticket/54582 yet, you may wish to hold of on decisions until that goes through. |
@peterwilsoncc Thanks for the ping. As you already noticed, any patch to upgrade Requests to the 2.x series depends on Trac #54582 being fixed first. Also be aware that this patch was created 7 months ago and will need more than just a rebase to fix merge conflicts.
This patch can serve as a basis/inspiration for a new patch, but should by no means by regarded as a viable patch to go into Core as is, by now. |
0425c8e
to
593f744
Compare
Closing this PR in favor of #3732. |
External libraries: upgrade to Requests 2.0.0
Upgrade references to the Requests library in the WP code
Trac ticket: https://core.trac.wordpress.org/ticket/54504
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.