Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Requests 2.0.0 #1624

Closed
wants to merge 5 commits into from

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 27, 2021

External libraries: upgrade to Requests 2.0.0

Upgrade references to the Requests library in the WP code

Trac ticket: https://core.trac.wordpress.org/ticket/54504


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@jrfnl
Copy link
Member Author

jrfnl commented Sep 3, 2021

Rebased and updated to test the latest changes in the Requests library.

@jrfnl jrfnl force-pushed the test/upgrade-to-requests-2.0 branch from 272938b to 6ed8afa Compare September 11, 2021 02:57
@jrfnl jrfnl force-pushed the test/upgrade-to-requests-2.0 branch from 6ed8afa to 76fdec4 Compare November 12, 2021 21:44
@jrfnl jrfnl changed the base branch from master to trunk November 12, 2021 21:45
@jrfnl jrfnl force-pushed the test/upgrade-to-requests-2.0 branch from 76fdec4 to 2d7768f Compare November 16, 2021 13:25
@jrfnl jrfnl force-pushed the test/upgrade-to-requests-2.0 branch from 2d7768f to 0425c8e Compare November 24, 2021 15:05
@jrfnl jrfnl changed the title [WIP/Test] Upgrade to Requests 2.0.0 Upgrade to Requests 2.0.0 Nov 24, 2021
@jrfnl jrfnl marked this pull request as ready for review November 24, 2021 15:07
@jrfnl
Copy link
Member Author

jrfnl commented Nov 24, 2021

Marked as ready for review and updated with the final Requests 2.0.0 code.

@jrfnl
Copy link
Member Author

jrfnl commented Nov 25, 2021

Closing as committed via changeset 52244.

@jrfnl jrfnl closed this Nov 25, 2021
@jrfnl
Copy link
Member Author

jrfnl commented Feb 8, 2022

Re-opening as the commit was reverted.

@peterwilsoncc
Copy link
Contributor

This has got a merge conflict and and older version of Requests.

@jrfnl:

  • do you still wish to get the requests bump in WP 6.0?
  • if so, which version? I saw there was a release in the last 24 hours or so.

The trac ticket for upgrade is tagged early, and the beta is two weeks away so it would be good to see something soonish.

Mainly for my own notes: for the purposes of testing this is a randomly selected before zip file.

@peterwilsoncc
Copy link
Contributor

Sorry @jrfnl, I just noticed there isn't a patch for https://core.trac.wordpress.org/ticket/54582 yet, you may wish to hold of on decisions until that goes through.

@jrfnl
Copy link
Member Author

jrfnl commented Mar 29, 2022

This has got a merge conflict and and older version of Requests.

@jrfnl:

* do you still wish to get the requests bump in WP 6.0?
* if so, which version? I saw there was a release in the last 24 hours or so.

The trac ticket for upgrade is tagged early, and the beta is two weeks away so it would be good to see something soonish.

Mainly for my own notes: for the purposes of testing this is a randomly selected before zip file.

Sorry @jrfnl, I just noticed there isn't a patch for https://core.trac.wordpress.org/ticket/54582 yet, you may wish to hold of on decisions until that goes through.

@peterwilsoncc Thanks for the ping. As you already noticed, any patch to upgrade Requests to the 2.x series depends on Trac #54582 being fixed first.

Also be aware that this patch was created 7 months ago and will need more than just a rebase to fix merge conflicts.

  • A new search will have to be done across the WP codebase to find all uses of the old Requests classes and replace them as new code referencing the old classes may have been introduced in the mean time.
  • The Requests files will need an update to version 2.0.1 (or 2.0.2, though for the purposes of WP, 2.0.2 contains no changes from 2.0.1 other than the version number constant as the only difference is an updated certificate bundle and WP uses its own); or depending on when Trac#54582 is resolved, whatever the current version of Requests is by that time.

This patch can serve as a basis/inspiration for a new patch, but should by no means by regarded as a viable patch to go into Core as is, by now.

@hellofromtonya
Copy link
Contributor

Closing this PR in favor of #3732.

@jrfnl jrfnl deleted the test/upgrade-to-requests-2.0 branch December 8, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants